Prepare release v4.12.0 #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhij
reviewed
Aug 16, 2024
CHANGELOG.md
Outdated
| Update Go to 1.23 | ||
| Update other go.mod dependencies | ||
| Update VolumeSnapshot, VolumeSnapshotContents, and VolumeSnapshotClasses CRDs to pull in CEL validation rules new in external-snapshotter v8 release | ||
| Remove VolumeSnapshot and VolumeSnapshotContets from the snapshot validating webhook configuration as those are now validated via CEL rules on their CRDs |
There was a problem hiding this comment.
nit: typo with VolumeSnapshotContets
dhij
reviewed
Aug 16, 2024
| ## v4.12.0 - 2024.08.16 | ||
|
|
||
| * Update CSI driver for Kubernetes 1.31 | ||
| Update CSI sidecars to latest |
There was a problem hiding this comment.
i think it will be cleaner to have them in bullet points * like done below and also link the relevant PRs 🙂
There was a problem hiding this comment.
They're all in the same PR though
There was a problem hiding this comment.
Oh it's all going in the same paragraph when rendered. Let me find something better
There was a problem hiding this comment.
Added newlines so that in the rendered .md those are kept on separate lines
Still a single PR though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got wondering for a bit if this should be a major release or not, due to the breaking change in exernal-snapshotter we pulled in, but ultimately decided it's not a breaking change for csi-digitalocean
UPD: I'm probably overthinking it. The 4.12.0 version is for do-csi-plugin, the validating webhook configuration is just here so that we can e2e testing and for convenience